gh-112536: Define MI_TSAN to 1 for --with-mimalloc and --with-thread-sanitizer #116558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Suggested from: #112648 (comment) |
erlend-aasland
changed the title
erlend-aasland
previously approved these changes
Mar 10, 2024
colesbury
reviewed
Mar 10, 2024
configure.ac
Outdated
| @@ -4750,6 +4750,12 @@ elif test "$disable_gil" = "yes"; then | |||
| AC_MSG_ERROR([--disable-gil requires mimalloc memory allocator (--with-mimalloc).]) | |||
| fi | |||
|
|
|||
| if test "$with_mimalloc" = yes; then | |||
| if test "$with_tsan" = yes; then | |||
| AC_DEFINE([MI_TSAN], [1], [Define MI_TSAN for mimalloc thread sanitizer support]) | |||
There was a problem hiding this comment.
I think we should do this in pycore_mimalloc.h instead. We already do that for MI_DEBUG and some other defines.
Something like:
#ifdef _Py_THREAD_SANITIZER
# define MI_TSAN 1
#endif
There was a problem hiding this comment.
Hm, yes that looks like a better solution.
erlend-aasland
approved these changes
Mar 11, 2024
colesbury
approved these changes
Mar 11, 2024
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sanitizer
--with-thread-sanitizer#112536